Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validator count log #14600

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Remove validator count log #14600

merged 7 commits into from
Nov 1, 2024

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Nov 1, 2024

What type of PR is this?

Other

What does this PR do? Why is it needed?

We shouldn't be counting total validators just to print a log for queue position of a validator. Calling the validators count endpoint isn't standard and removing a call to it from the validator client will put us closer to the path of standardization. Logs are updated in accordance.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@james-prysm james-prysm marked this pull request as ready for review November 1, 2024 14:56
@james-prysm james-prysm requested a review from a team as a code owner November 1, 2024 14:56
@james-prysm james-prysm added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit f2ade3c Nov 1, 2024
18 checks passed
@james-prysm james-prysm deleted the remove-validator-count-log branch November 1, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants